#847 Ensure that RecordSerializer can deal with subtypes
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RecordSerializercurrently fails to deserialize abstract/non-final component types, because it doesn't include concrete type information in the serialized bytes.It would be possible to solve this in a backwards-compatible way, but that would force users to opt-in to the the correct behavior. I think we should make an exception in this case, break compatibility, and allow users who already have records serialized with the flawed implementation to selectively enable backwards-compatibility for existing records.
This will have to be documented clearly in the release notes for Kryo 5.2.0.
Resolves #847.